RFR: 8242295: Move files from vmTestbase/nsk/monitoring/ThreadMBean into ThreadMXBean
Leonid Mesnik
leonid.mesnik at oracle.com
Tue Apr 7 23:26:50 UTC 2020
I didn't want to touch unrelated files and spread this fix outside
vmTestbase/nsk/monitoring/ThreadMBean package. I wanted just to merge
folders to don't confuse people by layout.
The ThreadMBean is mentioned also in
test/jdk/sun/management/jmxremote/bootstrap/
files and
src/jdk.management.agent/share/conf/management.properties
Also sometimes just MBean used to point to corresponding MXBean in
comments. (Might it is a correct to use MBean there)
So, let just change ThreadMBean in nsk/monitoring/stress/thread/ and
stop updating comments on this.
BTW, I will change summary to
8242295: Change ThreadMBean in vmTestbase/nsk/monitoring to ThreadMXBean
to better describe changes
Leonid
On 4/7/20 4:06 PM, Igor Ignatyev wrote:
> great! what about nsk/monitoring/stress/thread/ ? they all have lines
> 'and states gotten via the ThreadMBean interface.' (strace010.java
> has 3 occurrences, other files just one)
>
> -- Igor
>
>> On Apr 7, 2020, at 3:56 PM, Leonid Mesnik <leonid.mesnik at oracle.com
>> <mailto:leonid.mesnik at oracle.com>> wrote:
>>
>> Sure
>>
>> I've updated ThreadMBean to ThreadMXBean in test descriptions for
>> ThreadMXBean tests .
>>
>> http://cr.openjdk.java.net/~lmesnik/8242295/webrev.01/
>>
>> Leonid
>>
>> On 4/7/20 3:00 PM, Igor Ignatyev wrote:
>>> Hi Leonid,
>>>
>>> looks good and trivial to me. one question, will it also make sense
>>> to replace ThreadMBean w/ ThreadMXBean in test descriptions, e.g. at
>>> L#33 of
>>> test/hotspot/jtreg/vmTestbase/nsk/monitoring/ThreadMXBean/isCurrentThreadCpuTimeSupported/curthcputime001/TestDescription.java?
>>>
>>> Thanks,
>>> -- Igor
>>>
>>>> On Apr 7, 2020, at 2:46 PM, Leonid Mesnik <leonid.mesnik at oracle.com
>>>> <mailto:leonid.mesnik at oracle.com>> wrote:
>>>>
>>>> Hi
>>>> Could you please review following fix which just moves content
>>>> of ThreadMBean back into ThreadMXBean.
>>>>
>>>> webrev: http://cr.openjdk.java.net/~lmesnik/8242295/webrev.00/
>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8242295
>>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20200407/908c9b95/attachment.htm>
More information about the serviceability-dev
mailing list