RFR(M) 8240990: convert clhsdb "dumpclass" command from javascript to java

serguei.spitsyn at oracle.com serguei.spitsyn at oracle.com
Wed Apr 8 05:19:57 UTC 2020


Hi Chris,

It looks good to me.

Thanks,
Serguei

On 4/7/20 20:12, Chris Plummer wrote:
> Hello,
>
> Please review the following:
>
> https://bugs.openjdk.java.net/browse/JDK-8240990
> http://cr.openjdk.java.net/~cjplummer/8240990/webrev.00
>
> The javascript code was just a few lines like other recent commands, 
> but it had quite a bit of support on the java side in 
> JSJavaScriptEngine.dumpClass(), which needed some massaging when moved 
> to CommandProcessor.java. The CR contains the javascript and java code 
> that was converted.
>
> thanks,
>
> Chris



More information about the serviceability-dev mailing list