RFR(XS) 8242265: serviceability/sa/ClhsdbScanOops.java fails due to bad @requires expression

Leonid Mesnik leonid.mesnik at oracle.com
Wed Apr 8 05:38:58 UTC 2020


Looks good, thank you for fixing this.
Leonid

> On Apr 7, 2020, at 9:57 PM, Chris Plummer <chris.plummer at oracle.com> wrote:
> 
> Hello,
> 
> Please review the following:
> 
> https://bugs.openjdk.java.net/browse/JDK-8242265
> 
> diff --git a/test/hotspot/jtreg/serviceability/sa/ClhsdbScanOops.java b/test/hotspot/jtreg/serviceability/sa/ClhsdbScanOops.java
> --- a/test/hotspot/jtreg/serviceability/sa/ClhsdbScanOops.java
> +++ b/test/hotspot/jtreg/serviceability/sa/ClhsdbScanOops.java
> @@ -25,7 +25,7 @@
>   * @test
>   * @bug 8192985
>   * @summary Test the clhsdb 'scanoops' command
> - * @requires vm.gc.ParallelGC
> + * @requires vm.gc.Parallel
>   * @requires vm.hasSA
>   * @library /test/lib
>   * @run main/othervm/timeout=1200 ClhsdbScanOops UseParallelGC
> @@ -35,7 +35,7 @@
>   * @test
>   * @bug 8192985
>   * @summary Test the clhsdb 'scanoops' command
> - * @requires vm.gc.SerialGC
> + * @requires vm.gc.Serial
>   * @requires vm.hasSA
>   * @library /test/lib
>   * @run main/othervm/timeout=1200 ClhsdbScanOops UseSerialGC
> 
> I tested by removing the tests from our problem list so now they are actually run (and would see the reported failure if not fixed).
> 
> thanks,
> 
> Chris
> 



More information about the serviceability-dev mailing list