RFR: JDK-8242282: Test sun/tools/jps/TestJps.java fails after JDK-8237572

[Chris Plummer]

Hi Alex,

Please add a newline between lines 70 and 71.

   77         // are writen the jar manifest.

"writen" -> "written to"

No need to see another review.

thanks,

Chris

On 4/9/20 3:50 PM, Alex Menkov wrote:
> Hi Chris,
>
> I tried to describe main idea of the code.
>
> updated webrev:
> http://cr.openjdk.java.net/~amenkov/jdk15/jpsTest_ClsNotFound/webrev.01/
>
> the only change vs prev. webrev is added comment in 
> LingeredAppForJps.java
>
> --alex
>
> On 04/09/2020 14:28, Chris Plummer wrote:
>> Hi Alex,
>>
>> The fix looks good, but the test is in need of some commenting. It 
>> took a fair amount of staring at the code,  the CR, and the RFR to 
>> figure out what it is doing and why. Can you add a few comments?
>>
>> // Add the main class to the jar file. It should only be found in one 
>> classpath, therefore only added once.
>>
>> // Keep track of all classpaths other than the one that the main 
>> class is in.
>>
>> // Write all additional classpaths to the jar manifest
>>
>> thanks,
>>
>> Chris
>>
>> On 4/9/20 1:42 PM, Alex Menkov wrote:
>>> Hi all,
>>>
>>> Please review the fix for
>>> https://bugs.openjdk.java.net/browse/JDK-8242282
>>> webrev:
>>> http://cr.openjdk.java.net/~amenkov/jdk15/jpsTest_ClsNotFound/webrev/
>>>
>>> The test creates jar with test classes and run it with "java -jar 
>>> <jar_file>".
>>> The problem is single "@run Test" tag is executed by JTreg 
>>> inconsistently - sometimes library classes are compiled to test 
>>> directory, sometimes - to library directory.
>>> The fix explicitly forces required library classes compilation (so 
>>> library files are compiled to library dir) and add classpath 
>>> directories to jar manifest.
>>>
>>> --alex
>>
>>