RFR(S/T) : 8242313 : use reproducible random in hotspot svc tests

[Chris Plummer]

Looks good.

thanks,

Chris

On 4/13/20 10:36 AM, Igor Ignatyev wrote:
> ping?
> -- Igor
>
>> On Apr 8, 2020, at 10:21 AM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
>>
>> http://cr.openjdk.java.net/~iignatyev//8242313/webrev.00
>>> 16 lines changed: 10 ins; 0 del; 6 mod;
>> Hi all,
>>
>> could you please review the patch which updates hotspot/jtreg/serviceability tests in the same way as 8242310[1,2] updates compiler tests:
>>> marks ... tests w/ randomness k/w and uses Utils.getRandomInstance() instead of Random w/ _random_ seeds where possible? To identify tests which should be marked, I've used both static (in a form of analyzing classes which directly or indirectly depend on Random/SecureRandom/ThreadLocalRandom) and dynamic (by instrumenting the said classes to log tests which called their 'next' methods) analyses. I've decided *not* to mark tests which use SecureRandom only via File.createTemp* b/c in all such cases temp files are not used as a source of randomness, but rather just a reliable way to get a new/empty file/dir.
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8242313
>> webrev: http://cr.openjdk.java.net/~iignatyev/8242313/webrev.00
>> NB the patch depends on 8241707[3], which is currently under review[4].
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8242310
>> [2] https://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2020-April/037828.html
>> [3] https://bugs.openjdk.java.net/browse/JDK-8241707
>> [4] https://mail.openjdk.java.net/pipermail/hotspot-dev/2020-April/041300.html
>>
>> Thanks,
>> -- Igor