RFR(XS) 8237250: pmap and pstack should do a better of making it clear that they are not supported on Mac OS X

serguei.spitsyn at oracle.com serguei.spitsyn at oracle.com
Mon Apr 13 22:49:19 UTC 2020


Hi Chris,

LGTM++

Thanks,
Serguei


On 4/13/20 15:33, Alex Menkov wrote:
> LGTM
>
> --alex
>
> On 04/13/2020 13:30, Chris Plummer wrote:
>> Ping!
>>
>> This one is pretty trivial. You don't really need to know anything 
>> about PMap and PStack to review. It's just cleaning up how they fail 
>> due due not being supported on OSX, and also adjusting the tests to 
>> detect the failure.
>>
>> thanks,
>>
>> Chris
>>
>> On 4/9/20 3:55 PM, Chris Plummer wrote:
>>> Hello,
>>>
>>> Please review the following:
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8237250
>>> http://cr.openjdk.java.net/~cjplummer/8237250/webrev.01/index.html
>>>
>>> Details are in the CR.
>>>
>>> thanks,
>>>
>>> Chris
>>



More information about the serviceability-dev mailing list