RFR (T) 8242896: typo #ifdef INCLUDE_JVMTI in codeCache.cpp

coleen.phillimore at oracle.com coleen.phillimore at oracle.com
Thu Apr 16 02:37:34 UTC 2020



On 4/15/20 9:37 PM, David Holmes wrote:
> Hi Coleen,
>
> On 16/04/2020 10:59 am, coleen.phillimore at oracle.com wrote:
>> open webrev at 
>> http://cr.openjdk.java.net/~coleenp/2020/8242896.01/webrev
>> bug link https://bugs.openjdk.java.net/browse/JDK-8242896
>
> Looks good but ...
>
>> Built and ran vmTestbase RedefineTests which use the protected code.
>
> ... you need to ensure that builds that don't INCLUDE_JVMTI still work 
> okay as they will now actually be excluding this code for the first time.

Last time I tried to build minimal, it failed for some odd problem on my 
system.  I'll wait until someone from the openjdk can build it then.
thanks,
Coleen
>
> Thanks,
> David
>
>> thanks,
>> Coleen



More information about the serviceability-dev mailing list