RFR (S): 8242237: Improve JVM TI HiddenClasses tests
Leonid Mesnik
leonid.mesnik at oracle.com
Fri Apr 24 22:11:20 UTC 2020
Looks good.
The small nit (optional). New function
287 static void JNICALL
288 ClassPrepare(jvmtiEnv* jvmti, JNIEnv* jni, jthread thread, jclass klass) {
is very similar to ClassLoad, and verification of signature might be moved into common function.
Leonid
> On Apr 24, 2020, at 11:31 AM, serguei.spitsyn at oracle.com wrote:
>
> Please, review a fix for the sub-task:
> https://bugs.openjdk.java.net/browse/JDK-8242237 <https://bugs.openjdk.java.net/browse/JDK-8242237>
>
> Webrev:
> http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jvmti-hidden-test-update.1/ <http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jvmti-hidden-test-update.1/>
>
> Summary:
> The test update includes:
> - interface and method renaming: Test => HCInterf, test() => hcMethod()
> - readClassFile replaced with Files.readAllBytes
> - added ClassPrepare event
> - removed unneeded capability can_get_source_file_name
> - added more comments
>
> Testing:
> Tested locally on Linux, mach5 test run is in progress:
> https://mach5.us.oracle.com/mdash/jobs/sspitsyn-HiddenClass-jvmti-test-20200424-1829-10485216 <https://mach5.us.oracle.com/mdash/jobs/sspitsyn-HiddenClass-jvmti-test-20200424-1829-10485216>
>
> Thanks,
> Serguei
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20200424/992e43ad/attachment.htm>
More information about the serviceability-dev
mailing list