RFR: JDK-8242522: Minor LingeredApp improvements

[Alex Menkov]

Hi Chris,

On 04/24/2020 15:42, Chris Plummer wrote:
> Hi Alex,
> 
> Overall it looks good, although I'm not so sure I agree with removing 
> getAppOutput(). It's a generally useful utility API. Seems it is better 
> off in LingeredApp.java rather than in the one test that currently uses it.

To me the method just adds noise to the class.
If you think it can be useful for some other tests, I'd move it to to 
OutputBuffer (make it default method which uses OutputBuffer.getStdout()):

default public List<String> getStdOutAsList()

--alex

> 
> thanks,
> 
> Chris
> 
> On 4/24/20 3:17 PM, Alex Menkov wrote:
>> Hi all,
>>
>> Please review the fix for
>> https://bugs.openjdk.java.net/browse/JDK-8242522
>> webrev:
>> http://cr.openjdk.java.net/~amenkov/jdk15/LingeredApp_improve/webrev/
>>
>> The fix contains minor fixes/improvements for LingeredApp and tests 
>> which use it. See jira for details.
>>
>> Tested all tests which use LingeredApp.
>>
>> --alex
>