RFR(S/T) : 8243568 : serviceability/logging/TestLogRotation.java uses 'test.java.opts' and not 'test.vm.opts'

[David Holmes]

On 25/04/2020 11:51 pm, Igor Ignatev wrote:
> Thanks Chris. I can’t help but wonder if we should move all tests from serviceability/logging to runtime then.

Actually unified logging (JEP 158) was defined as a serviceability feature:

https://bugs.openjdk.java.net/browse/JDK-8046148

IIUC the core functional tests are under serviceability/logging, whereas 
a test that relates to logging of a particular item in the VM is filed 
under the component area of the item.

Anyway this fix seems fine to me.

Thanks,
David


> — Igor
> 
>> On Apr 24, 2020, at 3:53 PM, Chris Plummer <Chris.Plummer at oracle.com> wrote:
>>
>> Adding hotspot-runtime-dev since logging is owned by runtime, not serviceability.
>>
>> Chris
>>
>>> On 4/24/20 3:41 PM, Leonid Mesnik wrote:
>>> Looks good. (Need a 'R'eview.)
>>>
>>> Leonid.
>>>
>>>>> On Apr 24, 2020, at 3:30 PM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
>>>>
>>>> http://cr.openjdk.java.net/~iignatyev//8243568/webrev.00
>>>>> 8 lines changed: 0 ins; 6 del; 2 mod;
>>>> Hi all,
>>>>
>>>> could you please review this small and trivial patch which updates serviceability/logging/TestLogRotation.java test to pass both 'test.java.opts' and not 'test.vm.opts' ? to do that, the patch removes the custom logic of handling test.java.opts and just uses ProcessTools.createJavaProcessBuilder(boolean addTestVmAndJavaOptions=true, String...), which prepends values of both properties.
>>>> from JBS:
>>>>> serviceability/logging/TestLogRotation.java test use 'test.java.opts' to get external vm flags, yet actually external flags are split b/w 'test.java.opts' and 'test.vm.opts' and in the majority of cases all external flags are set listed in 'test.vm.opts' so the test should be updated to read both.
>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8243568
>>>> webrev: http://cr.openjdk.java.net/~iignatyev//8243568/webrev.00
>>>>
>>>> Thanks,
>>>> -- Igor
>>
>