RFR (S): 8242237: Improve JVM TI HiddenClasses tests

[Alex Menkov]

Hi Serguei,

LGTM++

--alex

On 04/24/2020 15:20, serguei.spitsyn at oracle.com wrote:
> Hi Leonid,
> 
> Thank you for review and suggestion.
> Will fix it.
> 
> Thanks,
> Serguei
> 
> 
> On 4/24/20 15:11, Leonid Mesnik wrote:
>> Looks good.
>>
>> The small nit (optional). New function
>>   287 static void JNICALL
>>   288 ClassPrepare(jvmtiEnv* jvmti, JNIEnv* jni, jthread thread, jclass klass) {
>>
>> is very similar to ClassLoad, and verification of signature might be 
>> moved into common function.
>>
>> Leonid
>>
>>> On Apr 24, 2020, at 11:31 AM, serguei.spitsyn at oracle.com 
>>> <mailto:serguei.spitsyn at oracle.com> wrote:
>>>
>>> Please, review a fix for the sub-task:
>>> https://bugs.openjdk.java.net/browse/JDK-8242237
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jvmti-hidden-test-update.1/
>>>
>>> Summary:
>>>   The test update includes:
>>>    - interface and method renaming: Test => HCInterf, test() => 
>>> hcMethod()
>>>    - readClassFile replaced with Files.readAllBytes
>>>    - added ClassPrepare event
>>>    - removed unneeded capability can_get_source_file_name
>>>    - added more comments
>>>
>>> Testing:
>>>   Tested locally on Linux, mach5 test run is in progress:
>>> https://mach5.us.oracle.com/mdash/jobs/sspitsyn-HiddenClass-jvmti-test-20200424-1829-10485216
>>>
>>> Thanks,
>>> Serguei
>>>
>>
>