RFR: JDK-8251384: [TESTBUG] jvmti tests should not be executed with minimal VM

Igor Ignatyev igor.ignatyev at oracle.com
Thu Aug 20 16:23:31 UTC 2020


HI Alex,

one minor nit: according to usual java coding conventions, isJVMTIIncluded should be spelled as isJvmtiIncluded. otherwise the fix looks good to me.

> Other tests will be updated in the follow-ups.
have you already identified all the tests which need this @requires? filed bugs/RFEs for them?

Cheers,
-- Igor


> On Aug 19, 2020, at 6:02 PM, Alex Menkov <alexey.menkov at oracle.com> wrote:
> 
> Hi all,
> 
> please review the fix for
> https://bugs.openjdk.java.net/browse/JDK-8251384
> webrev:
> http://cr.openjdk.java.net/~amenkov/jdk16/minimal_jvmti/webrev/
> 
> The fix introduces new @requires option "vm.jvmti":
> test/lib/sun/hotspot/WhiteBox.java
> test/jtreg-ext/requires/VMProps.java
> src/hotspot/share/prims/whitebox.cpp
> test/hotspot/jtreg/TEST.ROOT
> 
> and updates tests in test/hotspot/jtreg/serviceability/jvmti (the only change in all tests is added "@requires vm.jvmti")
> Other tests will be updated in the follow-ups.
> 
> The



More information about the serviceability-dev mailing list