RFR(T) : 8252005 : narrow disabling of allowSmartActionArgs in vmTestbase

[Igor Ignatyev]

thanks Serguei, pushed.

-- Igor

> On Aug 20, 2020, at 10:55 AM, serguei.spitsyn at oracle.com wrote:
> 
> Hi Igor,
> 
> Still looks good to me.
> The webrev is veeeeery slow.
> 
> Thanks,
> Serguei
> 
> 
> On 8/20/20 10:16, Igor Ignatyev wrote:
>> Hi Serguei,
>> 
>> thanks for your review. I've decided to slightly modify the patch and use the ids of subtasks in TEST.properties files (instead of main bug id) in order to avoid possible confusion in the future:
>>  - incremental: http://cr.openjdk.java.net/~iignatyev//8252005/webrev.0-1/index.html <http://cr.openjdk.java.net/~iignatyev//8252005/webrev.0-1/index.html>
>>  - whole: http://cr.openjdk.java.net/~iignatyev//8252005/webrev.01/index.html <http://cr.openjdk.java.net/~iignatyev//8252005/webrev.01/index.html>
>> 
>> could you please re-review it?
>> 
>> Thanks,
>> -- Igor
>> 
>>> On Aug 19, 2020, at 4:22 PM, serguei.spitsyn at oracle.com <mailto:serguei.spitsyn at oracle.com> wrote:
>>> 
>>> Hi Igor,
>>> 
>>> This looks reasonable.
>>> 
>>> Thanks,
>>> Serguei
>>> 
>>> 
>>> On 8/18/20 16:42, Igor Ignatyev wrote:
>>>> http://cr.openjdk.java.net/~iignatyev//8252005/webrev.00/ <http://cr.openjdk.java.net/~iignatyev//8252005/webrev.00/>
>>>>> 0 lines changed: 0 ins; 0 del; 0 mod;
>>>> Hi all,
>>>> 
>>>> could you please review this trivial (and apparently empty) patch which sets allowSmartActionArgs to false only in subdirectories of vmTestbase which currently use PropertyResolvingWrapper?
>>>> 
>>>> (it's hard to tell from webrev or patch, but test/hotspot/jtreg/vmTestbase/TEST.properties is effectively removed)
>>>> 
>>>> webrev: http://cr.openjdk.java.net/~iignatyev//8252005/webrev.00/ <http://cr.openjdk.java.net/~iignatyev//8252005/webrev.00/>
>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8252005 <https://bugs.openjdk.java.net/browse/JDK-8252005>
>>>> 
>>>> Thanks,
>>>> -- Igor
>>>> 
>>>> 
>>> 
>> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20200820/c46801fb/attachment.htm>