RFR: JDK-8251384: [TESTBUG] jvmti tests should not be executed with minimal VM

Alex Menkov alexey.menkov at oracle.com
Thu Aug 20 18:50:53 UTC 2020


Hi Serguei,

On 08/19/2020 20:34, serguei.spitsyn at oracle.com wrote:
> Hi Alex,
> 
> It looks good to me.
> 
> But there are more tests in test/hotspot/jtreg/runtime and 
> test/hotspot/jtreg/compiler which use the Instrumentation API, and so, 
> depend on the JVMTI.
> 
> Examples are:
>    test/hotspot/jtreg/compiler/jsr292
> test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test 
> 
>    test/hotspot/jtreg/compiler/profiling/spectrapredefineclass
>    test/hotspot/jtreg/runtime/Metaspace/DefineClass.java
>    test/hotspot/jtreg/runtime/cds/appcds/cacheObject
>    test/hotspot/jtreg/runtime/cds/appcds/javaldr
>    test/hotspot/jtreg/runtime/cds/appcds/jvmti
>    test/hotspot/jtreg/runtime/records
>    test/hotspot/jtreg/runtime/sealedClasses
> 
> I wonder if you are aware about these tests and have any plan for them.

Looks like you missed this:

 >> and updates tests in test/hotspot/jtreg/serviceability/jvmti (the only
 >> change in all tests is added "@requires vm.jvmti")
 >> Other tests will be updated in the follow-ups.

The are many tests which needs to be updated in test/hotspot and test/jdk

--alex

> 
> Thanks,
> Serguei
> 
> 
> On 8/19/20 18:02, Alex Menkov wrote:
>> Hi all,
>>
>> please review the fix for
>> https://bugs.openjdk.java.net/browse/JDK-8251384
>> webrev:
>> http://cr.openjdk.java.net/~amenkov/jdk16/minimal_jvmti/webrev/
>>
>> The fix introduces new @requires option "vm.jvmti":
>> test/lib/sun/hotspot/WhiteBox.java
>> test/jtreg-ext/requires/VMProps.java
>> src/hotspot/share/prims/whitebox.cpp
>> test/hotspot/jtreg/TEST.ROOT
>>
>> and updates tests in test/hotspot/jtreg/serviceability/jvmti (the only 
>> change in all tests is added "@requires vm.jvmti")
>> Other tests will be updated in the follow-ups.
>>
>> The
> 


More information about the serviceability-dev mailing list