RFR: 8256808: com/sun/jdi/CatchAllTest.java failed with "NullPointerException: Cannot invoke "lib.jdb.Jdb.log(String)" because "this.jdb" is null" [v2]
Serguei Spitsyn
sspitsyn at openjdk.java.net
Wed Dec 2 01:12:59 UTC 2020
On Tue, 1 Dec 2020 21:05:12 GMT, Alex Menkov <amenkov at openjdk.org> wrote:
>> JdbTest can get exception before jdb field is initialized.
>> As Jdb logging does not depend on the instance, made Jdb.log method static
>
> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
>
> Updated accordingly feedback
>
> - made Jdb.log instance private method (I'd prefer to keep the method as a single point to logging);
> - updated JdbTest to use System.out.println directly.
Looks good
-------------
Marked as reviewed by sspitsyn (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/1443
More information about the serviceability-dev
mailing list