RFR: 8255381: com/sun/jdi/EATests.java should not suspend graal threads [v3]

Chris Plummer cjplummer at openjdk.java.net
Tue Dec 8 19:28:38 UTC 2020


On Tue, 8 Dec 2020 14:00:25 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

>> This fixes a bug in the test test/jdk/com/sun/jdi/EATests.java that caused
>> timeout failures when graal is enabled.
>> 
>> The fix is to avoid suspending all threads when a breakpoint is reached and then resume
>> just the main thread again. This pattern was used in the test case
>> EAMaterializeLocalAtObjectPollReturnReturn. It caused timeouts because graal
>> threads remained suspended and, running with -Xbatch, the main thread waited
>> (with timeout) for completion of compile tasks.
>> The fix was applied to all breakpoints in the test. All explicit suspend calls now apply only
>> to the main test thread and all explicit resume calls apply to all java threads.
>> 
>> Testing: duration of the test case EAMaterializeLocalAtObjectPollReturnReturn is
>> reduced from 30s to 10s.
>
> Richard Reingruber has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Only main thread needs to be resumed in EARelockingObjectCurrentlyWaitingOn.

Marked as reviewed by cjplummer (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/1625


More information about the serviceability-dev mailing list