RFR: 8253797: [cgroups v2] Account for the fact that swap accounting is disabled on some systems
    Harold Seigel 
    hseigel at openjdk.java.net
       
    Thu Dec 10 16:31:33 UTC 2020
    
    
  
On Mon, 7 Dec 2020 17:48:01 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:
> This has been implemented for cgroups v1 with [JDK-8250984](https://bugs.openjdk.java.net/browse/JDK-8250984) but was lacking some tooling support for cgroups v2. With podman 2.2.0 release this could now be implemented (and tested). The idea is the same as for the cgroups v1 fix. If we've got no swap limit capabilities, return the memory limit only.
> 
> Note that for cgroups v2 doesn't implement CgroupV1Metrics (obviously) and, thus, doesn't have `getMemoryAndSwapFailCount()` and `getMemoryAndSwapMaxUsage()`.
> 
> Testing:
> - [x] submit testing
> - [x] container tests on cgroups v2 with swapaccount=0.
> - [x] Manual container tests involving `-XshowSettings:system` on cgroups v2.
> 
> Thoughts?
The changes look good.  Thanks for doing this.
Harold
-------------
Marked as reviewed by hseigel (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/1672
    
    
More information about the serviceability-dev
mailing list