[jdk16] RFR: 8255381: com/sun/jdi/EATests.java should not suspend graal threads

Richard Reingruber rrich at openjdk.java.net
Fri Dec 11 09:24:05 UTC 2020


This is a clone of https://github.com/openjdk/jdk/pull/1625 which was reviewed but not integrated before RDP1

The change is a test bug fix which can be integrated during RDP1 according to https://openjdk.java.net/jeps/3

--- Original Synopsis

This fixes a bug in the test test/jdk/com/sun/jdi/EATests.java that caused
timeout failures when graal is enabled.

The fix is to avoid suspending all threads when a breakpoint is reached and then resume
just the main thread again. This pattern was used in the test case
EAMaterializeLocalAtObjectPollReturnReturn. It caused timeouts because graal
threads remained suspended and, running with -Xbatch, the main thread waited
(with timeout) for completion of compile tasks.
The fix was applied to all breakpoints in the test. All explicit suspend calls now apply only
to the main test thread and all explicit resume calls apply to all java threads.

Testing: duration of the test case EAMaterializeLocalAtObjectPollReturnReturn is
reduced from 30s to 10s.

-------------

Commit messages:
 - Only main thread needs to be resumed in EARelockingObjectCurrentlyWaitingOn.
 - Changes based on Chris Plummer's feedback.
 - 8255381: com/sun/jdi/EATests.java should not suspend graal threads

Changes: https://git.openjdk.java.net/jdk16/pull/7/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk16&pr=7&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8255381
  Stats: 90 lines in 2 files changed: 34 ins; 10 del; 46 mod
  Patch: https://git.openjdk.java.net/jdk16/pull/7.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk16 pull/7/head:pull/7

PR: https://git.openjdk.java.net/jdk16/pull/7


More information about the serviceability-dev mailing list