RFR: 8165276: Spec states to invoke the premain method in an agent class if it's public but implementation differs [v2]

Serguei Spitsyn sspitsyn at openjdk.java.net
Fri Dec 11 18:08:58 UTC 2020


On Thu, 10 Dec 2020 23:57:46 GMT, Mandy Chung <mchung at openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   removed lookup for inherited premain/agentmain methods
>
> Please update @bug in the tests to include this bug ID.
> 
> All InheritAgentXXX tests are updated to have the InheritAgentXXX class public.  However, I think you need to go through them individually for this behavioral change.   The existing comments may not be applicable and please update them where appropriate.    For example InheritAgent0100 previously verifies the invocation of the premain in its superclass.  Does the modified test ensure that this fails to load?  Per the comment in the new InheritAgent0100Super class, it expects the superclass' premain should be called.

Mandy, thank you for comments.
You are right, the comments at 429-443 tests need some updates. I'm working on it now.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1694


More information about the serviceability-dev mailing list