RFR: 8258061: Improve diagnostic information about errors during class redefinition [v2]

Serguei Spitsyn sspitsyn at openjdk.java.net
Fri Dec 18 03:20:59 UTC 2020


On Thu, 17 Dec 2020 22:54:13 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> The error code during class redefinition might be not enough to easily diagnose the problem. Some more logging might be useful to understand it. I encountered this problem when redefined methods with lambda usage.
>> I run all existing tests with enabled logging and sanity verified error messages.
>
> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
> 
>   updated log_trace to log_info

Hi Leonid,
It is useful and looks good.
Just one nit:
This line can be split after the comma:
`1047         ("redefined class %s fields change error: some fields were %s.", the_class->external_name(), action); `
Thanks,
Serguei

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1811


More information about the serviceability-dev mailing list