RFR: 8165276: Spec states to invoke the premain method in an agent class if it's public but implementation differs [v9]
Serguei Spitsyn
sspitsyn at openjdk.java.net
Tue Dec 22 22:14:56 UTC 2020
On Mon, 21 Dec 2020 20:04:39 GMT, Mandy Chung <mchung at openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 1. Suppress premain method check only if agent class is in unnamed module; 2. minor tests cleanup
>
> The change looks okay with minor comments on the tests. Nit: it will be good to update `@summary` in the InheritAgentxxxx tests that now fail to load the agent.
@mlchung
Thank you for the catch! Fixed it.
Also, reverted the fix in the NativeMethodPrefixAgent.java.
Additionally, got rid of the 'inherited' term in the summary of InheritAgent*.java tests.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1694
More information about the serviceability-dev
mailing list