RFR: JDK-8238710: LingeredApp doesn't log stdout/stderr if exits with non-zero code

[Alex Menkov]

Hi Chris,

thanks for the review.
finishApp is also called from startApp(String... cmd) method
and appProcess can be not initialized there.
In the case finishApp will throw NPE (calling appProcess.exitValue())

--alex

On 02/12/2020 13:53, Chris Plummer wrote:
> Hi Alex,
> 
> Thanks for doing this. Not having output from a spawned process that 
> failed is an issue with more than just LingeredApp tests. This is a good 
> start in getting those fixed.
> 
> I'm a little unclear on one part of your fix. Why did you move the 
> "appProcess != null" into finishApp(). You already make that check in 
> stopApp(). If anything it looks like that check should have been there 
> before your changes, but is no longer needed after your changes.
> 
> thanks,
> 
> Chris
> 
> On 2/12/20 1:28 PM, Alex Menkov wrote:
>> Hi all,
>>
>> Please review small fix for
>> https://bugs.openjdk.java.net/browse/JDK-8238710
>> webrev:
>> http://cr.openjdk.java.net/~amenkov/jdk15/LingeredApp_log_error/webrev/
>>
>> --alex
>