RFR 8232622: Technical debt in BadAttributeValueExpException

Roger Riggs Roger.Riggs at oracle.com
Thu Feb 13 18:18:34 UTC 2020


Hi Daniel,

That's part of the technical debt that has to go.

The change to do the conversion in the constructor has been there since 
JDK8.
And the value of the argument is informative.

There isn't too much overhead in keeping them but the are just noise at 
this point.

Thanks, Roger


On 2/13/20 12:38 PM, Daniel Fuchs wrote:
> Hi Roger,
>
> I think you will need to preserve these cases:
>
> On 13/02/2020 15:52, Roger Riggs wrote:
>> -                || valObj instanceof Long
>> -                || valObj instanceof Integer
>> -                || valObj instanceof Float
>> -                || valObj instanceof Double
>> -                || valObj instanceof Byte
>> -                || valObj instanceof Short
>> -                || valObj instanceof Boolean) {
>
> They could legitimately be transmitted by an older unpatched JVM.
> we don't want to use System.identityHashCode(valObj) + "@" + 
> valObj.getClass().getName(); for these.
>
> best regards,
>
> -- daniel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20200213/d7da223d/attachment.htm>


More information about the serviceability-dev mailing list