[PING] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy

[Bob Vandette]

> On Feb 18, 2020, at 2:00 PM, Mandy Chung <mandy.chung at oracle.com> wrote:
> 
> 
> 
> On 2/18/20 4:50 AM, Severin Gehwolf wrote:
>> Hi Mandy,
>> 
>> Thanks again for the review!
>> 
>> Updated webrev:
>> incremental (only review changes): 
>> http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8231111/11/incremental/webrev/
>> 
>> full: 
>> http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8231111/11/webrev/
> 
> This looks good.  I only skimmed on the tests and not reviewed in details (I assume Bob has reviewed them).   

Yes, I checked the tests and they look fine.

Bob.

> 
>  All new cgroup-specific and metrics implementation classes are now linux-specific classes which is good.
> 
>> More below.
>> 
>> 
>> 
>>> test/lib/jdk/test/lib/containers/cgroup/MetricsTester.java
>>>    The Oracle copyright is taken out and the copyright is also changed from GPL to GPL+CP.
>>>    The Red Hat copyright can be added to the top of the file immediately before "DO NOT ALTER or REMOVE" line like [1].
>>> 
>>> [1] 
>>> http://hg.openjdk.java.net/jdk/jdk/file/tip/test/hotspot/jtreg/compiler/onSpinWait/TestOnSpinWaitEnableDisable.java
>> Hmm, old MetricsTester got renamed with this patch to
>> MetricsTesterCgroupV1. MetricsTesterCgroupV1 still has the old
>> copyright. The version you've looked at is the common part and
>> instantiates tester for cgroup v1 or cgroup v2 as required.
>> 
> 
> Thanks for clarifying.  I now see that MetricsTester.java is a new file in this patch but the webrev shows as an existing file.  
> 
>> Aside: Not sure why old MetricsTester (or new MetricsTesterCgroupV1) is
>> GPL (over GPL+CP).
>> Either way, I've changed license to GPL over GPL+CP for the new test
>> classes with Red Hat copyright.
>> 
> 
> I skimmed through the copyright header and license text.  Looks fine to me.
> 
> Mandy
>