RFR: JDK-8222489: jcmd VM.system_properties gives unusable paths on Windows

Yasumasa Suenaga suenaga at oss.nttdata.com
Thu Feb 20 00:34:20 UTC 2020


Hi Chihiro,

I think this problem is caused by spec of `Properties::store(Writer)`.

`Properties::store(OutputStream)` says that the output format is as same as `store(Writer)` [1].
`Properties::store(Writer)` says that `#`, `!`, `=`, `:` are written with a preceding backslash [2].

So I think we should not use `Properties::store` to serialize properties.


Thanks,

Yasumasa


[1] https://download.java.net/java/early_access/jdk15/docs/api/java.base/java/util/Properties.html#store(java.io.OutputStream,java.lang.String)
[2] https://download.java.net/java/early_access/jdk15/docs/api/java.base/java/util/Properties.html#store(java.io.Writer,java.lang.String)


On 2020/02/19 22:36, Chihiro Ito wrote:
> Hi,
> 
> Could you review this tiny fix, please?
> 
> This problem affected not the only path on Windows, but also Linux and URLs using ":".
> 
> Webrev : http://cr.openjdk.java.net/~cito/JDK-8222489/webrev.00/
> JBS : https://bugs.openjdk.java.net/browse/JDK-8222489
> 
> Regards,
> Chihiro


More information about the serviceability-dev mailing list