RFR(XS): 8239856: [ntintel] asserts about copying unaligned array element

[Doerr, Martin]

Hi Serguei,

thanks for the review.

Best regards,
Martin


From: serguei.spitsyn at oracle.com <serguei.spitsyn at oracle.com>
Sent: Montag, 24. Februar 2020 20:12
To: Doerr, Martin <martin.doerr at sap.com>; OpenJDK Serviceability <serviceability-dev at openjdk.java.net>
Subject: Re: RFR(XS): 8239856: [ntintel] asserts about copying unaligned array element

Hi Martin,

It looks good to me.

Thanks,
Serguei


On 2/24/20 05:51, Doerr, Martin wrote:
Hi,

reposting on serviceability-dev (was core-libs-dev before).

Bug:
https://bugs.openjdk.java.net/browse/JDK-8239856

Webrev:
http://cr.openjdk.java.net/~mdoerr/8239856_win32_long_double_align/webrev.00/

Thanks for the review, Thomas!

Best regards,
Martin


From: Thomas Stüfe <thomas.stuefe at gmail.com><mailto:thomas.stuefe at gmail.com>
Sent: Montag, 24. Februar 2020 14:41
To: Doerr, Martin <martin.doerr at sap.com><mailto:martin.doerr at sap.com>
Cc: core-libs-dev at openjdk.java.net<mailto:core-libs-dev at openjdk.java.net>; Lindenmaier, Goetz <goetz.lindenmaier at sap.com><mailto:goetz.lindenmaier at sap.com>; Langer, Christoph <christoph.langer at sap.com><mailto:christoph.langer at sap.com>
Subject: Re: RFR(XS): 8239856: [ntintel] asserts about copying unaligned array element

Oh okay. Then it looks okay to me.

Cheers, Thomas

On Mon, Feb 24, 2020 at 12:56 PM Doerr, Martin <martin.doerr at sap.com<mailto:martin.doerr at sap.com>> wrote:
Hi Thomas,

thanks for the quick review.

ATTRIBUTE_ALIGNED is defined in hotspot. I can’t use it for src/jdk.jdwp.agent/share/native/libjdwp/ArrayReferenceImpl.c.

Christoph had already suggested to make it available for core libs, too, but I haven’t found a good place for it.

Best regards,
Martin


From: Thomas Stüfe <thomas.stuefe at gmail.com<mailto:thomas.stuefe at gmail.com>>
Sent: Montag, 24. Februar 2020 12:52
To: Doerr, Martin <martin.doerr at sap.com<mailto:martin.doerr at sap.com>>
Cc: core-libs-dev at openjdk.java.net<mailto:core-libs-dev at openjdk.java.net>; Lindenmaier, Goetz <goetz.lindenmaier at sap.com<mailto:goetz.lindenmaier at sap.com>>; Langer, Christoph <christoph.langer at sap.com<mailto:christoph.langer at sap.com>>
Subject: Re: RFR(XS): 8239856: [ntintel] asserts about copying unaligned array element

Hi Martin,

maybe use ATTRIBUTE_ALIGNED instead?

Cheers, Thomas

On Mon, Feb 24, 2020 at 12:44 PM Doerr, Martin <martin.doerr at sap.com<mailto:martin.doerr at sap.com>> wrote:
Hi,

we had fixed stack array alignment for Windows 32 bit with JDK-8220348.
However, there are also stack allocated jlong and jdouble used as source for SetLongArrayRegion and SetDoubleArrayRegion with insufficient alignment for this platform.

Here’s my proposed fix:
http://cr.openjdk.java.net/~mdoerr/8239856_win32_long_double_align/webrev.00/

Please review.

Best regards,
Martin


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20200225/15012ea8/attachment-0001.htm>