RFR(XXS): 8236124: Minimal VM slowdebug build failed after JDK-8212160

serguei.spitsyn at oracle.com serguei.spitsyn at oracle.com
Tue Jan 7 05:15:50 UTC 2020


Thank you for review, David!
Serguei

On 1/6/20 8:54 PM, David Holmes wrote:
> On 7/01/2020 2:09 pm, serguei.spitsyn at oracle.com wrote:
>> Hi Coleen,
>>
>> Thank you for reviewing it!
>> I've sent another trivial patch as suggested by Chris.
>> It is for better consistency.
>
> Yes much better. It makes little sense having a JVMTI_ONLY macro 
> inside a method that is littered with JVMTI code.
>
> Thanks,
> David
>
>> Thanks,
>> Seguei
>>
>>
>> On 1/6/20 6:29 PM, coleen.phillimore at oracle.com wrote:
>>> This looks trivial.  Thank you for fixing it.
>>> Coleen
>>>
>>> On 1/6/20 9:18 PM, serguei.spitsyn at oracle.com wrote:
>>>> Please, review a trivial fix for bug:
>>>>   https://bugs.openjdk.java.net/browse/JDK-8236124
>>>>
>>>> Patch suggested by A. Shipilev:
>>>>
>>>> diff --git a/src/hotspot/share/code/nmethod.cpp 
>>>> b/src/hotspot/share/code/nmethod.cpp
>>>> --- a/src/hotspot/share/code/nmethod.cpp
>>>> +++ b/src/hotspot/share/code/nmethod.cpp
>>>> @@ -1601,7 +1601,7 @@
>>>>        ServiceThread::enqueue_deferred_event(&event);
>>>>      } else {
>>>>        // This enters the nmethod barrier outside in the caller.
>>>> -      state->enqueue_event(&event);
>>>> +      JVMTI_ONLY(state->enqueue_event(&event));
>>>>      }
>>>>    }
>>>>  }
>>>>
>>>>
>>>> Summary:
>>>>   The slowdebug build was broken by the fix of JDK-8212160 which 
>>>> introduced new function: enqueue_event().
>>>>   The fix is to call it only if the JVM TI is enabled.
>>>>
>>>> Testing:
>>>>   Ran slowdebug build locally.
>>>>
>>>> Thanks,
>>>> Serguei
>>>
>>



More information about the serviceability-dev mailing list