RFR (XS): 8237008: Exclude serviceability/sa/TestInstanceKlassSizeForInterface.java on linuxppc64 and linuxppc64le

[Langer, Christoph]

Hi Coleen,

why it's failing on ppc or ppcle was analyzed in https://bugs.openjdk.java.net/browse/JDK-8230664. You can read in the description:

The test retrieves the size of Java classes by 2 different APIs and expects the result to be equal:
- SA reports the size of the reserved memory. Rounded up to a multiple of 16 on PPC64.
- Jcmd GC.class_stats reports the size of the space needed for a number of 8 Byte blocks. (The number is from an internal statistic.)
So there may be a difference of 8 Bytes on platforms which reserve memory 16 Byte wise.

I assume that the functionality from Jcmd GC.class_stats was replaced in your change but goes back to the same statistics.

In our tests we set test.vm.opts, so I guess that's why we don't see failures on other platforms.

Best regards
Christoph




> -----Original Message-----
> From: coleen.phillimore at oracle.com <coleen.phillimore at oracle.com>
> Sent: Montag, 13. Januar 2020 15:22
> To: Langer, Christoph <christoph.langer at sap.com>; David Holmes
> <david.holmes at oracle.com>; hotspot-dev at openjdk.java.net; Doerr, Martin
> <martin.doerr at sap.com>
> Cc: OpenJDK Serviceability <serviceability-dev at openjdk.java.net>
> Subject: Re: RFR (XS): 8237008: Exclude
> serviceability/sa/TestInstanceKlassSizeForInterface.java on linuxppc64 and
> linuxppc64le
> 
> Hi, I didn't see this with my filtering.  Do you know why it fails for
> ppcle?
> 
> It fails for us on all platforms because test.vm.opts isn't set in our
> CI jobs.
> 
> Thanks,
> Coleen
> 
> On 1/13/20 8:26 AM, Langer, Christoph wrote:
> > Hi David,
> >
> > thanks for the heads up. However, in our CI, these tests pass on all
> platforms except linuxppc64/linuxppc64le consistently.
> >
> > I think I'll push the exclusion and once JDK-8236917 has been resolved I'll
> try on the ppc linuxes again...
> >
> > Best regards
> > Christoph
> >
> >> -----Original Message-----
> >> From: David Holmes <david.holmes at oracle.com>
> >> Sent: Montag, 13. Januar 2020 13:57
> >> To: Langer, Christoph <christoph.langer at sap.com>; hotspot-
> >> dev at openjdk.java.net; Doerr, Martin <martin.doerr at sap.com>
> >> Cc: OpenJDK Serviceability <serviceability-dev at openjdk.java.net>
> >> Subject: Re: RFR (XS): 8237008: Exclude
> >> serviceability/sa/TestInstanceKlassSizeForInterface.java on linuxppc64
> and
> >> linuxppc64le
> >>
> >> Hi Christoph,
> >>
> >> I think those tests are currnetly failing on all platforms - see
> >> JDK-8236917. The failures after GC.class_stats removal are unrelated to
> >> the failures reported in 8230664 AFAICS.
> >>
> >> David
> >>
> >> On 13/01/2020 8:23 pm, Langer, Christoph wrote:
> >>> Hi,
> >>>
> >>> after JDK-8232759 "Remove GC.class_stats" [0] was pushed, we see the
> >>> test "serviceability/sa/TestInstanceKlassSizeForInterface.java" failing
> >>> on linuxppc64 and linuxppc64le the same way as
> >>> "serviceability/sa/TestInstanceKlassSize.java". Hence, I'm requesting
> >>> the same exclusion of TestInstanceKlassSizeForInterface (referring to
> >>> JDK-8230664 [1] for resolution).
> >>>
> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8237008
> >>>
> >>> Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8237008.0/
> >>>
> >>> Thanks
> >>>
> >>> Christoph
> >>>
> >>> [0] https://hg.openjdk.java.net/jdk/jdk/rev/d8f6e926cedc
> >>>
> >>> [1] https://bugs.openjdk.java.net/browse/JDK-8230664
> >>>