RFR: 8236873: Worker has a deadlock bug

David Holmes david.holmes at oracle.com
Wed Jan 15 22:28:00 UTC 2020


+1

David

On 16/01/2020 4:41 am, Daniel Fuchs wrote:
> Hi Daniil,
> 
> That looks fine to me.
> 
> best regards,
> 
> -- daniel
> 
> On 15/01/2020 18:15, Daniil Titov wrote:
>> Please review a change [1] that fixes a deadlock issue [2] in 
>> sun.tools.jconsole.Worker class.
>>
>> There is no need in guarding "stopped" flag by a lock. The fix removes 
>> this excessive locking and
>> instead makes the flag volatile.
>>
>> Mach5 tier1-tier3 tests passed.
>>
>> [1] Webrev : http://cr.openjdk.java.net/~dtitov/8236873/webrev.01/
>> [2] Issue: https://bugs.openjdk.java.net/browse/JDK-8236873
>>
>> Best regards,
>> Daniil
>>
>>
> 


More information about the serviceability-dev mailing list