[15] RFR(T) 8247527: serviceability/dcmd/gc/HeapDumpCompressedTest.java fails with Graal + ZGC

Igor Ignatyev igor.ignatyev at oracle.com
Fri Jul 3 02:59:35 UTC 2020


Hi David,

it's in my todo list to improve this situation and have vm.gc.X to take selected JIT into account; and update existing (>200) occurrences of 'vm.gc.X & !vm.graal.enabled' 

-- Igor

> On Jul 2, 2020, at 7:25 PM, David Holmes <david.holmes at oracle.com> wrote:
> 
> Hi Vladimir,
> 
> On 3/07/2020 12:02 pm, Vladimir Kozlov wrote:
>> https://cr.openjdk.java.net/~kvn/8247527/webrev.00/
>> https://bugs.openjdk.java.net/browse/JDK-8247527
>> Test should have @requires which excludes running Graal with GC which it does not support.
> 
> I find it somewhat disturbing that a generic test has to know about the limitations between GCs and Graal!
> 
> I would have been more inclined to just exclude this test when running with Graal, even if that theoretically reduced the test coverage in a ting way.
> 
> If/When Graal supports these other GCs who will remember to re-enable these test cases?
> 
> Thanks,
> David
> 
>> Testing: hs-tier1,hs-tier4-graal
>> Thanks,
>> Vladimir



More information about the serviceability-dev mailing list