RFR(M): 8247515: OSX pc_to_symbol() lookup does not work with core files

[Kevin Walls]

Hi Chris,

Yes I think this looks good.

Question: In nearest_symbol, do we need to initialize 
lowest_offset_from_sym to something impossibly high, as if it defaults 
to zero we never find a better/nearer result?

Thanks
Kevin


On 07/07/2020 06:10, Chris Plummer wrote:
> Hello,
>
> Please help review the following:
>
> http://cr.openjdk.java.net/~cjplummer/8247515/webrev.00/index.html
> https://bugs.openjdk.java.net/browse/JDK-8247515
>
> The CR contains a description of the issues being addressed. There is 
> also no test for this symbol lookup support yet. It will be there 
> after I push JDK-8247516 and  JDK-8247514, which are both blocked by 
> the CR.
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8247516
> [2] https://bugs.openjdk.java.net/browse/JDK-8247514
>
> thanks,
>
> Chris
>