RFR [15] : 8249028 : clean up FileInstaller $test.src $cwd in vmTestbase_nsk_monitoring tests

[David Holmes]

Looks good!

Thanks,
David

On 9/07/2020 3:21 am, Igor Ignatyev wrote:
> http://cr.openjdk.java.net/~iignatyev/8249028/webrev.00/
>> 547 lines changed: 0 ins; 361 del; 186 mod;
> 
> Hi all,
> 
> could you please review the patch which removes `FileInstaller . .` jtreg action from :vmTestbase_nsk_monitoring tests?
> from the main issue(8204985):
>> all vmTestbase tests have '@run driver jdk.test.lib.FileInstaller . .' to mimic old test harness behavior and copy all files from a test source directory to a current work directory. some tests depend on this step, so we need 1st identify such tests and then either rewrite them not to have this dependency or leave FileInstaller only in these tests.
> 
> effectively, the patch is just `ag -l  '@run driver jdk.test.lib.FileInstaller . .'  vmTestbase/nsk/monitoring  | xargs -I{} gsed -i '/@run driver jdk.test.lib.FileInstaller \. \./d' {}`
> 
> testing: :vmTestbase_nsk_monitoring on linux-x64
> webrev: http://cr.openjdk.java.net/~iignatyev//8249018/webrev.00
> JBS: https://bugs.openjdk.java.net/browse/JDK-8249028
> 
> Thanks,
> -- Igor
> 
>