RFR [15] : 8249035 : clean up FileInstaller $test.src $cwd in vmTestbase_nsk_jdwp tests

[Igor Ignatyev]

Thanks David,

pushed to jdk15.

-- Igor

> On Jul 13, 2020, at 7:51 PM, David Holmes <david.holmes at oracle.com> wrote:
> 
> Looks good!
> 
> Thanks,
> David
> 
> On 14/07/2020 8:40 am, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev/8249035/webrev.00/
>>> 251 lines changed: 0 ins; 128 del; 123 mod;
>> Hi all,
>> could you please review this clean-up which removes `FileInstaller` actions from : vmTestbase_nsk_jdwp tests?
>> from the main issue(8204985):
>>> all vmTestbase tests have '@run driver jdk.test.lib.FileInstaller . .' to mimic old test harness behavior and copy all files from a test source directory to a current work directory. some tests depend on this step, so we need 1st identify such tests and then either rewrite them not to have this dependency or leave FileInstaller only in these tests.
>> the majority of the patch is created by `ag -l  '@run driver jdk.test.lib.FileInstaller . .' vmTestbase/nsk/jdwp xargs -I{} gsed -i '/@run driver jdk.test.lib.FileInstaller \. \./d' {}`. only two tests needed FileInstaller: VirtualMachine/RedefineClasses/redefinecls001 and Method/IsObsolete/isobsolete002. both tests have been updated to use aux class nsk.share.ExtraClassesBuilder, which search for source files in test.src (as opposed to current directory) instead of calling javac by ExecDriver; b/c n.s.ExtraClassesBuilder puts compiled classes into ./bin/newclass, the test code had to be slightly updated to search for classfiles in bin/newclass instead of newclass.
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8249035
>> webrev: http://cr.openjdk.java.net/~iignatyev//8249035/webrev.00/
>> testing: :vmTestbase_nsk_jdwp on linux-x64
>> Thanks,
>> -- Igor