RFR(XS): 8248879: SA core file support on OSX has some bugs trying to locate the jvm libraries
Chris Plummer
chris.plummer at oracle.com
Tue Jul 14 20:43:26 UTC 2020
Actually it's not so easy. I don't see any other references to strrstr
in our source. When I reference strstr, it gives a warning because it's
not declared. The only man page I can find says to include sstring2.h,
but this file does not exist. It also says to link with -lsstrings2.
Chris
On 7/14/20 1:37 PM, Chris Plummer wrote:
> Ok. I'll change both references to use strrstr.
>
> thanks,
>
> Chris
>
> On 7/14/20 1:11 PM, Alex Menkov wrote:
>> Hi Chris,
>>
>> I think it would be better to use strrstr to correctly handle paths like
>> /something/bin/jdk/bin/jhsdb
>>
>> And I'd updated
>> 358 char* posbin = strstr(execname, "/bin/java");
>> to use strrstr as well
>>
>> --alex
>>
>> On 07/14/2020 12:01, Chris Plummer wrote:
>>> Ping!
>>>
>>> On 7/6/20 9:31 PM, Chris Plummer wrote:
>>>> Hello,
>>>>
>>>> Please help review the following:
>>>>
>>>> http://cr.openjdk.java.net/~cjplummer/8248879/webrev.00/index.html
>>>> https://bugs.openjdk.java.net/browse/JDK-8248879
>>>>
>>>> The description of the problem and the fix are both in the CR.
>>>>
>>>> thanks,
>>>>
>>>> Chris
>>>
>
>
More information about the serviceability-dev
mailing list