RFR [15] : 8249039 : clean up FileInstaller $test.src $cwd in vmTestbase_nsk_aod tests

[serguei.spitsyn at oracle.com]

Hi Igor,

LGTM++

Thanks,
Serguei


On 7/14/20 16:41, David Holmes wrote:
> Hi Igor,
>
> LGTM.
>
> (Sorry I skipped this one yesterday. :) )
>
> Thanks,
> David
>
> On 14/07/2020 8:29 am, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev/8249039/webrev.00/
>>> 38 lines changed: 8 ins; 13 del; 17 mod;
>>
>> Hi all,
>>
>> could you please review this clean-up which removes `FileInstaller` 
>> actions from :vmTestbase_nsk_aod tests?
>> from the main issue(8204985):
>>> all vmTestbase tests have '@run driver jdk.test.lib.FileInstaller . 
>>> .' to mimic old test harness behavior and copy all files from a test 
>>> source directory to a current work directory. some tests depend on 
>>> this step, so we need 1st identify such tests and then either 
>>> rewrite them not to have this dependency or leave FileInstaller only 
>>> in these tests.
>>
>> VirtualMachine06 test assumed that manifest files are located in the 
>> current directory, the test has been updated to have ${test.src} in 
>> the path to manifests. all other vmTestbase_nsk_stress tests don't 
>> need FileInstaller, so the rest of the patch is produced by `ag -l  
>> '@run driver jdk.test.lib.FileInstaller . .' vmTestbase/nsk/aod xargs 
>> -I{} gsed -i '/@run driver jdk.test.lib.FileInstaller \. \./d' {}`.
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8249039
>> webrev: http://cr.openjdk.java.net/~iignatyev//8249039/webrev.00/
>> testing: :vmTestbase_nsk_aod on linux-x64
>>
>> Thanks,
>> -- Igor
>>