RFR (S) 8249822: SymbolPropertyTable creates an extra OopHandle per entry

serguei.spitsyn at oracle.com serguei.spitsyn at oracle.com
Thu Jul 23 00:53:49 UTC 2020


Hi Coleen,

The fix looks good to me.


On 7/22/20 13:55, coleen.phillimore at oracle.com wrote:
> Summary: Add an assert to OopHandle assigment operator to catch 
> leaking OopHandles, and fix code accordingly.
>
> There are some jvmtiRedefineClasses.cpp changes here - basically, I 
> moved the RedefineVerifyMark and comments into 
> jvmtiRedefineClasses.cpp because I needed a Handle.

I think, the jvmtiRedefineClasses.cpp is a better place for the 
RedefineVerifyMark.
But could you, please, explain a little bit more why this move was 
necessary?
Why Handle can not be used in the jvmtiThreadState.cpp?

Thanks,
Serguei


> Ran tier1-6 tests and tier1 on all Oracle platforms.
>
> open webrev at http://cr.openjdk.java.net/~coleenp/2020/8249822.01/webrev
> bug link https://bugs.openjdk.java.net/browse/JDK-8249822
>
> Thanks,
> Coleen



More information about the serviceability-dev mailing list