RFR (S) 8249822: SymbolPropertyTable creates an extra OopHandle per entry

[David Holmes]

On 23/07/2020 6:55 am, coleen.phillimore at oracle.com wrote:
> Summary: Add an assert to OopHandle assigment operator to catch leaking 
> OopHandles, and fix code accordingly.
> 
> There are some jvmtiRedefineClasses.cpp changes here - basically, I 
> moved the RedefineVerifyMark and comments into jvmtiRedefineClasses.cpp 
> because I needed a Handle.
> 
> Ran tier1-6 tests and tier1 on all Oracle platforms.
> 
> open webrev at http://cr.openjdk.java.net/~coleenp/2020/8249822.01/webrev
> bug link https://bugs.openjdk.java.net/browse/JDK-8249822

This all seems okay. A couple of minor nits

src/hotspot/share/oops/klass.cpp

+ void Klass::replace_java_mirror(oop mirror) { 
_java_mirror.replace(mirror); }

Writing this all in one line is inconsistent with surrounding style.

---

1226 //  a) A reference to the class being redefined (_the_class) and a
1230 //   b) The _java_mirror field from _the_class is copied to the

There's an extra space before b) on line 1230.

Thanks,
David
-----


> Thanks,
> Coleen