RFR(S) : 8183040 : update jdk/test/lib/Platform.java to use NIO file API
Alex Menkov
alexey.menkov at oracle.com
Wed Jun 10 01:36:11 UTC 2020
Hi Igor,
In SATestUtils.java you do
var bb = ... Files.readAllBytes(...) ...
and then use bb[0]
if the file has 0 length, old code throws EOFException and new one will
throw IndexOutOfBoundsException.
And looks like the caller doesn't expect it (it catches IOException).
--alex
On 06/09/2020 16:47, Igor Ignatyev wrote:
> http://cr.openjdk.java.net/~iignatyev//8183040/webrev.00
>>
>> 38 lines changed: 8 ins; 16 del; 14 mod;
>
> Hi all,
>
> could you please review this small clean up of testlibrary classes which updates j.t.lib.Platform and j.t.l.SA.SATestUtils (as it now contains the methods which 8183040 was about) to use NIO file API?
>
> testing: test/hotspot/jtreg/serviceability
> webrev: http://cr.openjdk.java.net/~iignatyev//8183040/webrev.00
> JBS: https://bugs.openjdk.java.net/browse/JDK-8183040
>
> Thanks,
> -- Igor
>
More information about the serviceability-dev
mailing list