RFR (S): 8245129: Enhance jstat gc option output and tests

[Volker Simonis]

Hi Paul,

thanks for fixing jstat for larger heaps. I like that you've added
explicit tests for ParallelGC which hasn't been tested since G1 was
made the default collector.

I also agree that sizes should all be right justified. I only wonder
if the header of a right justified column shouldn't be right justified
as well? However, taking into account that this already hasn't been
handled consistently before your change, I'm fine to postpone that to
a follow-up cleanup change.

I think the change looks good so thumbs up from me.

Thank you and best regards,
Volker


On Thu, Jun 18, 2020 at 11:53 PM Hohensee, Paul <hohensee at amazon.com> wrote:
>
> Ping. Any takers for this simple patch?
>
>
>
> Thanks,
>
> Paul
>
>
>
> From: serviceability-dev <serviceability-dev-bounces at openjdk.java.net> on behalf of "Hohensee, Paul" <hohensee at amazon.com>
> Date: Monday, May 18, 2020 at 8:25 AM
> To: serviceability-dev <serviceability-dev at openjdk.java.net>
> Subject: RFR (S): 8245129: Enhance jstat gc option output and tests
>
>
>
> Please review an enhancement to the jstat gc option output to make the columns wider (for up to a 2TB heap) so one can read the output without going cross-eyed.
>
>
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8245129
>
> Webrev: http://cr.openjdk.java.net/~phh/8245129/webrev.00/
>
>
>
> I added tests using ParallelGC since the output can differ for non-G1 collectors. Successfully ran the test/hotspot/jtreg/serviceability/tmtools/jstat and test/jdk/sun/tools/jstat tests. A submit repo run had one failure
>
>
>
> runtime/MemberName/MemberNameLeak.java
>
> tier1
>
> macosx-x64-debug
>
>
>
> but rerunning it on my laptop succeeded, and there’s no connection between this test and my patch.
>
>
>
> Thanks,
>
> Paul
>
>
>
>