15 RFR(XS): 8165276: Spec states that invoke the premain method in an agent class if it's public but implementation differs

[Mandy Chung]

Hi Serguei,

I'm glad that you have a patch for this.

On 6/23/20 7:05 PM, serguei.spitsyn at oracle.com wrote:
> Please, review a fix for:
>   https://bugs.openjdk.java.net/browse/JDK-8165276
>
>
> CSR draft (one CSR reviewer is needed before finalizing it):
>   https://bugs.openjdk.java.net/browse/JDK-8248189
>

The compatibility risk should be low (rather than minimal).

It says "All known Java agents define the premain method as public".  
It'd be useful to add a comment in the JBS issue to list the Java agents 
you have checked.

>
> Webrev:
> http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/instr-setAccessible.1/
>
>

Looks okay.  Can you add a test to verify this fix?

Mandy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20200623/19b25e90/attachment.htm>