jmx-dev RFR 8240604: Rewrite sun/management/jmxremote/bootstrap/CustomLauncherTest.java test to make binaries from source file

Dmitry Samersoff dms at samersoff.net
Tue Mar 17 14:02:24 UTC 2020


Hello Alexander,

The fix looks good for me.

-Dmitry

On 05.03.2020 17:27, Daniel Fuchs wrote:
> Hi Alexander,
> 
> Fixes to JMX & management agent are reviewed on the
> seviceability-dev (added in to:) these days.
> 
> best regards,
> 
> -- daniel
> 
> On 05/03/2020 13:17, Alexander Scherbatiy wrote:
>> Hello,
>>
>> Could you review a small enhancement where the test CustomLauncherTest 
>> is updated to build binary launcher file from launcher.c file.
>> The file launcher.c is renamed to exelauncher.c to follow the name 
>> convention for executable test files building by jdk make system.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8240604
>> Webrev: http://cr.openjdk.java.net/~alexsch/8240604/webrev.00
>>
>> The changes for obsolete binary files from 
>> sun/management/jmxremote/bootstrap/linux-* and solaris-* are not 
>> included into the webrev. They needs to be removed manually.
>>
>> The test is passed on Ubuntu 18.04 x86-64, Solaris Sparc v9 11.2, and 
>> Solaris x64 11.4 systems.
>>
>> The test is excluded from Windows and Mac Os X systems.
>>
>> Thanks,
>> Alexander.
> 



More information about the serviceability-dev mailing list