RFR: 8240698: LingeredApp does not pass getTestJavaOpts() to the children process if vmArguments is already specified

[Igor Ignatyev]

Hi Leonid,

I have briefly looked at the patch, a few comments so far:

test/hotspot/jtreg/serviceability/sa/ClhsdbFlags.java:
 - at L#114, could you please call static method using class name (as the opposite of using instance)? or was it meant to be theApp.runAppVmOpts(vmArgs) ?

test/lib/jdk/test/lib/apps/LingeredApp.java:
- it seems that code indent of startApp(LingeredApp, String[]) isn't correct
- I don't like startAppVmOpts name, but unfortunately don't have a better suggestion (yet)

Thanks,
-- Igor

> On Mar 25, 2020, at 8:55 AM, Leonid Mesnik <leonid.mesnik at oracle.com> wrote:
> 
> Hi
> 
> Could you please review following fix which change LingeredApp to prepend vm options to java/vm.test.opts when startApp is used and provide startAppVmOpts to override options completely.
> 
> The intention is to avoid issue like in this bug where test/jtreg options were ignored by tests. Also I fixed some tests where intention was to append vm options rather than to override them.
> 
> webrev: http://cr.openjdk.java.net/~lmesnik/8240698/webrev.00/
> 
> bug: https://bugs.openjdk.java.net/browse/JDK-8240698
> 
> Leonid
>