Review Request: 8238358: Implementation of JEP 371: Hidden Classes

Mandy Chung mandy.chung at oracle.com
Mon Mar 30 16:18:48 UTC 2020



On 3/30/20 7:16 AM, coleen.phillimore at oracle.com wrote:
>> I agree with you that this comment needs update.   Perhaps it should 
>> say "primitive, array types and hidden classes are non-modifiable. A 
>> modifiable class must be an InstanceKlass."
>
> I may have written the last part of that comment (or remember it at 
> least).  I think Chris's suggestion to remove the last sentence makes 
> sense.  Anything further will just adds unnecessary confusion to the 
> reader.  Anyone modifying this will get the InstanceKlass::cast() 
> assert soon after if they mess up. 

OK.  That's fine too.

Mandy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20200330/5d9ca788/attachment.htm>


More information about the serviceability-dev mailing list