RFR(S) : 8243435 : use reproducible random in :vmTestbase_nsk_jvmti
Chris Plummer
chris.plummer at oracle.com
Fri May 1 18:52:49 UTC 2020
Looks good.
Chris
On 5/1/20 9:33 AM, Igor Ignatyev wrote:
> Hi Serguei,
>
> thanks for the review. can I get 2nd review or ack. that this is trivial-ish and fine to be pushed w/ one reviewer?
>
> -- Igor
>
>> On Apr 30, 2020, at 11:24 PM, serguei.spitsyn at oracle.com wrote:
>>
>> This one looks good too.
>>
>> Thanks,
>> Serguei
>>
>>
>> On 4/30/20 16:46, Igor Ignatyev wrote:
>>> http://cr.openjdk.java.net/~iignatyev/8243435/webrev.00
>>>> 49 lines changed: 19 ins; 5 del; 25 mod;
>>> Hi all,
>>>
>>> could you please review this patch?
>>> from JBS:
>>>> this subtask is to use j.t.l.Utils.getRandomInstance() as a random number generator, where applicable, in : vmTestbase_nsk_jvmti test group and marking the tests which make use of "randomness" with a proper k/w.
>>> testing: : vmTestbase_nsk_jvmti test group
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8243435
>>> webrevs:
>>> - code changes: http://cr.openjdk.java.net/~iignatyev//8243435/webrev.00.code
>>>> 7 lines changed: 1 ins; 5 del; 1 mod;
>>> - adding k/w: http://cr.openjdk.java.net/~iignatyev//8243435/webrev.00.kw
>>>> 18 lines changed: 18 ins; 0 del; 0 mod;
>>> - full: http://cr.openjdk.java.net/~iignatyev//8243435/webrev.00
>>>> 49 lines changed: 19 ins; 5 del; 25 mod;
>>> Thanks,
>>> -- Igor
More information about the serviceability-dev
mailing list