RFR(S) : 8243437 : use reproducible random in :vmTestbase_nsk_jdi
Chris Plummer
chris.plummer at oracle.com
Fri May 1 19:04:42 UTC 2020
Looks good.
Chris
On 5/1/20 9:33 AM, Igor Ignatyev wrote:
> Hi Serguei,
>
> thanks for the review. can I get 2nd review or ack. that this is trivial-ish and fine to be pushed w/ one reviewer?
>
> -- Igor
>
>> On Apr 30, 2020, at 11:27 PM, serguei.spitsyn at oracle.com wrote:
>>
>> LGTM
>>
>> Thanks,
>> Serguei
>>
>>
>> On 4/30/20 16:52, Igor Ignatyev wrote:
>>> http://cr.openjdk.java.net/~iignatyev/8243437/webrev.00
>>>> 62 lines changed: 26 ins; 0 del; 36 mod;
>>> Hi all,
>>>
>>> could you please review this small patch?
>>> from JBS:
>>>> this subtask is to use j.t.l.Utils.getRandomInstance() as a random number generator, where applicable, in : vmTestbase_nsk_jdi test group and marking the tests which make use of "randomness" with a proper k/w.
>>> testing: : vmTestbase_nsk_jdi test group
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8243437
>>> webrev: http://cr.openjdk.java.net/~iignatyev/8243437/webrev.00
>>> (all code changes have already happened in 8242314 'use reproducible random in vmTestbase shared code', so just k/w and copyright years this time)
>>>
>>> Thanks,
>>> -- Igor
More information about the serviceability-dev
mailing list