RFR(S/M) : 8243436 : use reproducible random in :vmTestbase_nsk_monitoring

Igor Ignatyev igor.ignatyev at oracle.com
Fri May 1 23:26:16 UTC 2020


Thanks Chris, pushed.

-- Igor

> On May 1, 2020, at 11:20 AM, Chris Plummer <chris.plummer at oracle.com> wrote:
> 
> Looks good.
> 
> Chris
> 
> On 5/1/20 9:32 AM, Igor Ignatyev wrote:
>> Hi Serguei,
>> 
>> thanks for the review. can I get 2nd review or ack. that this is trivial-ish and fine to be pushed w/ one reviewer?
>> 
>> -- Igor
>> 
>>> On Apr 30, 2020, at 11:22 PM, serguei.spitsyn at oracle.com wrote:
>>> 
>>> Hi Igor,
>>> 
>>> It looks good.
>>> 
>>> Thanks,
>>> Serguei
>>> 
>>> 
>>> On 4/30/20 16:30, Igor Ignatyev wrote:
>>>> http://cr.openjdk.java.net/~iignatyev/8243436/webrev.00
>>>>> 305 lines changed: 76 ins; 11 del; 218 mod;
>>>> Hi all,
>>>> 
>>>> could you please review this patch?
>>>> from JBS:
>>>>> this subtask is to use j.t.l.Utils.getRandomInstance() as a random number generator, where applicable, in : vmTestbase_nsk_monitoring test group and marking the tests which make use of "randomness" with a proper k/w.
>>>> testing: : vmTestbase_nsk_monitoring test group
>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8243436
>>>> webrevs:
>>>> - code changes: http://cr.openjdk.java.net/~iignatyev//8243436/webrev.00.code
>>>>> 19 lines changed: 5 ins; 11 del; 3 mod;
>>>> - adding k/w: http://cr.openjdk.java.net/~iignatyev//8243436/webrev.00.kw
>>>>> 141 lines changed: 71 ins; 0 del; 70 mod;
>>>> - full: http://cr.openjdk.java.net/~iignatyev//8243436/webrev.00
>>>>> 305 lines changed: 76 ins; 11 del; 218 mod;
>>>> Thanks,
>>>> -- Igor
> 



More information about the serviceability-dev mailing list