RFR: 8244993: Revert changes to OutputAnalyzer stderrShouldBeEmptyIgnoreVMWarnings() that allow version strings

[Daniil Titov]

Hi David,

Some tiers in Mach5 are configured to run tests with '-showversion' VM options.  In JDK-8242009 [3] we started forwarding test VM options to j-*tools
and some tests that launch them and expect  an empty stderr (apart from VM warnings) need to be corrected to either ignore version messages in the output or to ensure that -showversion VM option is not passed to j*-tool even if it is passed to the test itself. 

Best regards,
Daniil



On 5/21/20, 10:41 PM, "David Holmes" <david.holmes at oracle.com> wrote:

    Hi Dannil,

    On 22/05/2020 3:06 pm, Daniil Titov wrote:
    > Please review a webrev [1] that reverts the changes done in jdk.test.lib.process.OutputAnalyzer in [3].
    > 
    > Change [3] modified OutputAnalyzer stderrShouldBeEmptyIgnoreVMWarnings() methods to ignore also VM version strings . The current webrev [1] reverts this change

    Thank you for reverting the OutputAnalyzer change.

    > and instead makes the tests that expects an empty stderr from launched j-* tools to filter out '-showversion' from test options when forwarding test VM option to j*-tools.

    That seems workable, though I'm unclear what is adding the 
    "-showversion" in the first place?

    Thanks,
    David
    -----

    > Testing: Mach5 tier1-tier5 tests passed successfully. Tier6-tier7 tests are in progress.
    > 
    > [1]  Webrev:  http://cr.openjdk.java.net/~dtitov/8244993/webrev.01
    > [2] Jira issue: https://bugs.openjdk.java.net/browse/JDK-8244993
    > [3] https://bugs.openjdk.java.net/browse/JDK-8242009
    > 
    > Thank you,
    > Daniil
    > 
    >