RFR: 8212879: Make JVMTI TagMap table concurrent [v2]

Erik Österlund eosterlund at openjdk.java.net
Tue Nov 3 10:25:00 UTC 2020


On Mon, 2 Nov 2020 16:22:57 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/share/prims/jvmtiTagMap.cpp line 345:
>> 
>>> 343: 
>>> 344:   // Check if we have to process for concurrent GCs.
>>> 345:   check_hashmap(false);
>> 
>> Maybe add a comment stating the parameter name, as was done in other callsites for check_hashmap.
>
> Ok, will I run afoul of the ZGC people putting the parameter name after the parameter and the rest of the code, it is before?

ZGC people passionately place the comment after the argument value.

-------------

PR: https://git.openjdk.java.net/jdk/pull/967


More information about the serviceability-dev mailing list