RFR: 8212879: Make JVMTI TagMap table concurrent [v2]

Coleen Phillimore coleenp at openjdk.java.net
Tue Nov 3 12:40:06 UTC 2020


On Tue, 3 Nov 2020 10:33:16 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Since I went back and forth about what this function did (it posted events at one time), I thought the generic _processing name would be better.  GC callers shouldn't really have to know what processing we're doing here.  Hopefully it won't change from rehashing.  That's why I like processing.
>
>>  GC callers shouldn't really have to know what processing we're doing here.
> 
> I completely disagree with this. It's extremely important that the GC and Runtime code agrees on what this code does and where the GC *must* call it. Knowing the details allows us to skip calling this after mark end, but forces us to call it in relocate start, when objects should start to move. Though, I don't want to block this review because of this point, so if you still thinks that a non-descriptive name is better then we can argue that separately.

Ok, I'll rename it to needs_hashing.

-------------

PR: https://git.openjdk.java.net/jdk/pull/967


More information about the serviceability-dev mailing list