RFR: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c

Coleen Phillimore coleenp at openjdk.java.net
Thu Nov 5 12:23:53 UTC 2020


On Thu, 5 Nov 2020 11:18:04 GMT, Claes Redestad <redestad at openjdk.org> wrote:

>> Please make sure `linux-x86` jobs pass in GH actions. I think you can navigate to https://github.com/coleenp/jdk/runs/1355854648 -- and press "Re-run jobs" at top right.
>
> FWIW I don't think I intended the workaround of specifying limits to be patched in as-is, although it seems benign to go ahead and do this. While it's possible that these warnings on 32-bit builds is just a matter of the compiler being wrong, it could also be that it can't determine all arguments are null-terminated. Specifying max string length in format specifiers seem a benign and cheap safeguard.

Thanks @dholmes-ora and @plummercj I don't know why the compiler is complaining but I'd like it to stop.  If this isn't the best way to do so, please suggest another workaround.  I could also open a new bug to investigate whatever the bug in the 32 bit compiler is and push this workaround, if you would like.

@shipilev there's something wrong with one of the github test machines (error for non-payment) that needs to be fixed.  This builds on 32 bit in our mach5 configuration.

And @cl4es thank you for the suggested workaround.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1067


More information about the serviceability-dev mailing list